fix for to_polygons when using processes instead of threads in dask #756
+11
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when configuring dask to use 'processes' instead of 'threads' ,
spatialdata.to_polygons
fails due to this line:spatialdata/src/spatialdata/_core/operations/vectorize.py
Line 212 in 27bb4a7
result of
dask.compute()
is lost when using processes, which is expected behaviour.Note that using 'processes' instead of 'threads' considerably speeds up vectorizing labels for large masks, because the function we try to parallelize does not release the GIL.
Example:
"segmentation_mask_full' contains the masks from a merscope experiment, around 300k labels.